[webkit-reviews] review granted: [Bug 232236] [CSS Cascade Layers] Support 'revert-layer' value : [Attachment 443534] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 8 08:27:12 PST 2021


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 232236: [CSS Cascade Layers] Support 'revert-layer' value
https://bugs.webkit.org/show_bug.cgi?id=232236

Attachment 443534: Patch

https://bugs.webkit.org/attachment.cgi?id=443534&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 443534
  --> https://bugs.webkit.org/attachment.cgi?id=443534
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443534&action=review

> Source/WebCore/style/CascadeLevel.h:39
> +inline CascadeLevel& operator--(CascadeLevel& level)

I wonder if it's worth giving this an explicit name.

> Source/WebCore/style/ElementRuleCollector.h:69
> +enum class FromStyleAttribute { No, Yes };

: bool ?


More information about the webkit-reviews mailing list