[webkit-reviews] review granted: [Bug 232663] Wavy decorations don't cover the whole line length : [Attachment 443276] Patch

[bugzilla-daemon at webkit.org]

Myles C. Maxfield <mmaxfield at apple.com> has granted Manuel Rego Casasnovas
<rego at igalia.com>'s request for review:
Bug 232663: Wavy decorations don't cover the whole line length
https://bugs.webkit.org/show_bug.cgi?id=232663

Attachment 443276: Patch

https://bugs.webkit.org/attachment.cgi?id=443276&action=review




--- Comment #8 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 443276
  --> https://bugs.webkit.org/attachment.cgi?id=443276
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443276&action=review

> LayoutTests/ChangeLog:6
> +	   Reviewed by NOBODY (OOPS!).

Instead of a DRT test, a better test would be something that draws text of a
known width under a big transform, and clips out everything except the area
under the text where there's no underline today, and compares that with an
-expected-mismatch test against pure white. That will make sure that we draw
something covering the entire span of text.