[webkit-reviews] review granted: [Bug 232772] [LFC][IFC] Process all replacement, control and opaque inline items. : [Attachment 443476] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Nov 6 06:35:44 PDT 2021


Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 232772: [LFC][IFC] Process all replacement, control and opaque inline
items.
https://bugs.webkit.org/show_bug.cgi?id=232772

Attachment 443476: Patch

https://bugs.webkit.org/attachment.cgi?id=443476&action=review




--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 443476
  --> https://bugs.webkit.org/attachment.cgi?id=443476
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443476&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:147
> +    size_t inlineTextBoxOffset = 0;
> +    for (size_t index = 0; index < inlineItems.size(); ++index) {

Could we reserverInitialCapacity() for InlineItemOffsetList and then use
uncheckedAppend?


More information about the webkit-reviews mailing list