[webkit-reviews] review granted: [Bug 232769] [iOS] IPC decoder for ResourceRequest loses systemPreviewInfo when there is platform data : [Attachment 443448] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 5 16:58:08 PDT 2021


Wenson Hsieh <wenson_hsieh at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 232769: [iOS] IPC decoder for ResourceRequest loses systemPreviewInfo when
there is platform data
https://bugs.webkit.org/show_bug.cgi?id=232769

Attachment 443448: Patch

https://bugs.webkit.org/attachment.cgi?id=443448&action=review




--- Comment #2 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 443448
  --> https://bugs.webkit.org/attachment.cgi?id=443448
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443448&action=review

> Source/WebKit/ChangeLog:8
> +	   The IPC decoder for ResourceRequest decoders systemPreviewInfo and
sets it on the ResourceRequest.

Nit - s/decoders/decodes/

> Source/WebKit/ChangeLog:11
> +	   which creates a brand-new ResourceRequest, and thus looses the
systemPreviewInfo we've just set.

Nit - s/looses/loses/


More information about the webkit-reviews mailing list