[webkit-reviews] review granted: [Bug 232736] [macOS] run-benchmark should take diagnostic screenshots upon test timeout : [Attachment 443358] Patch

[bugzilla-daemon at webkit.org]

dewei_zhu at apple.com has granted W.D. Xiong <wdx at apple.com>'s request for
review:
Bug 232736: [macOS] run-benchmark should take diagnostic screenshots upon test
timeout
https://bugs.webkit.org/show_bug.cgi?id=232736

Attachment 443358: Patch

https://bugs.webkit.org/attachment.cgi?id=443358&action=review




--- Comment #3 from dewei_zhu at apple.com ---
Comment on attachment 443358
  --> https://bugs.webkit.org/attachment.cgi?id=443358
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443358&action=review

r=me

> Tools/ChangeLog:8
> +	   Added diagnose_test_failure method to OSXBrowserDriver which cleans
the diagnostic directory and takes a screenshot if a directory is specified
(--diagnose-directory). 

Nit: this log line is too long, let's split it.