[webkit-reviews] review granted: [Bug 232740] Infinite loop in SourceBufferParserWebM::SegmentReader::Read : [Attachment 443364] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 232740: Infinite loop in SourceBufferParserWebM::SegmentReader::Read
https://bugs.webkit.org/show_bug.cgi?id=232740

Attachment 443364: Patch

https://bugs.webkit.org/attachment.cgi?id=443364&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 443364
  --> https://bugs.webkit.org/attachment.cgi?id=443364
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443364&action=review

r=me once the bots can deal with it

> Source/WebCore/ChangeLog:13
> +	   MTPluginByteSourceRead() call is failing and returning an error.
When an error occurrs, the

s/occurrs/occurs/

> Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.cpp:313
> +	       if (!readResult)

I thinks "!readResult.has_value()", like you use above, is clearer.

> Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.cpp:406
> +		   if (!readResult)

Ditto