[webkit-reviews] review granted: [Bug 232690] [Cocoa] Migrate from CTFontCopyVariationAxes() to CTFontCopyVariationAxesInternal() if possible : [Attachment 443279] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 232690: [Cocoa] Migrate from CTFontCopyVariationAxes() to
CTFontCopyVariationAxesInternal() if possible
https://bugs.webkit.org/show_bug.cgi?id=232690

Attachment 443279: Patch

https://bugs.webkit.org/attachment.cgi?id=443279&action=review




--- Comment #7 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 443279
  --> https://bugs.webkit.org/attachment.cgi?id=443279
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443279&action=review

> Source/WebCore/platform/graphics/ShouldLocalizeAxisNames.h:35
> +enum class ShouldLocalizeAxisNames : uint8_t {
> +    No,
> +    Yes
> +};

Is there a reason this can't just live in FontPlatformData.h?