[webkit-reviews] review granted: [Bug 231644] [css-values-4] viewport units should be floats : [Attachment 442065] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 231644: [css-values-4] viewport units should be floats
https://bugs.webkit.org/show_bug.cgi?id=231644

Attachment 442065: Patch

https://bugs.webkit.org/attachment.cgi?id=442065&action=review




--- Comment #4 from Tim Horton <thorton at apple.com> ---
Comment on attachment 442065
  --> https://bugs.webkit.org/attachment.cgi?id=442065
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442065&action=review

> Source/WebCore/ChangeLog:9
> +	   Views can be fractional pixels wide. We should not round, especially
since viewport units

>Views can be fractional pixels wide.

Technically true but many other parts of WebKit do not correctly support even
fractional *points* let alone fractional pixels. (Though I think you meant
points anyway?).

Still, no harm in this change.