[webkit-reviews] review granted: [Bug 232671] [Catalina] HLS streams will not select HDR variants when GPU Process is enabled : [Attachment 443212] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 232671: [Catalina] HLS streams will not select HDR variants when GPU
Process is enabled
https://bugs.webkit.org/show_bug.cgi?id=232671

Attachment 443212: Patch

https://bugs.webkit.org/attachment.cgi?id=443212&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 443212
  --> https://bugs.webkit.org/attachment.cgi?id=443212
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443212&action=review

> Source/WebKit/GPUProcess/mac/GPUProcessMac.mm:88
> +    if
(hasProcessPrivilege(ProcessPrivilege::CanCommunicateWithWindowServer)) {

Nit: this comment is confusing, does
"hasProcessPrivilege(ProcessPrivilege::CanCommunicateWithWindowServer)" imply
AVPlayer.videoRangeOverride isn't present?