[webkit-reviews] review granted: [Bug 232628] Leak of UUID in WebKit::ModelElementController::modelElementDidCreatePreview() : [Attachment 443101] Patch v1

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 232628: Leak of UUID in
WebKit::ModelElementController::modelElementDidCreatePreview()
https://bugs.webkit.org/show_bug.cgi?id=232628

Attachment 443101: Patch v1

https://bugs.webkit.org/attachment.cgi?id=443101&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 443101
  --> https://bugs.webkit.org/attachment.cgi?id=443101
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=443101&action=review

r=me

> Source/WebKit/UIProcess/Cocoa/ModelElementControllerCocoa.mm:133
> +    auto preview = adoptNS([allocASVInlinePreviewInstance()
initWithFrame:CGRectMake(0, 0, size.width(), size.height()) UUID:uuid.get()]);

Could also be:

auto preview = adoptNS([allocASVInlinePreviewInstance()
initWithFrame:CGRectMake(0, 0, size.width(), size.height())
UUID:adoptNS([[NSUUID alloc] initWithUUIDString:uuid]).get()]);