[webkit-reviews] review denied: [Bug 232650] Update whether an object is renderable : [Attachment 443157] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 3 10:32:13 PDT 2021


Simon Fraser (smfr) <simon.fraser at apple.com> has denied Brandon
<brandonstewart at apple.com>'s request for review:
Bug 232650: Update whether an object is renderable
https://bugs.webkit.org/show_bug.cgi?id=232650

Attachment 443157: Patch

https://bugs.webkit.org/attachment.cgi?id=443157&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 443157
  --> https://bugs.webkit.org/attachment.cgi?id=443157
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443157&action=review

> Source/WebCore/ChangeLog:8
> +	   No new tests needed.

You need some more words here for why this change makes sense. It looks like it
was copied from FloatRoundedRect::isRenderable(), so say that.

What's the consequence of the different behaviors of RoundedRect and
FloatRoundedRect? Explain here.


More information about the webkit-reviews mailing list