[webkit-reviews] review granted: [Bug 232665] ::slotted element style not invalidated correctly in nested case : [Attachment 443196] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 3 09:07:22 PDT 2021


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 232665: ::slotted element style not invalidated correctly in nested case
https://bugs.webkit.org/show_bug.cgi?id=232665

Attachment 443196: Patch

https://bugs.webkit.org/attachment.cgi?id=443196&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 443196
  --> https://bugs.webkit.org/attachment.cgi?id=443196
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443196&action=review

> Source/WebCore/ChangeLog:8
> +	   We fail to invalidae ::slotted style if the assinged node is not
from the current host scope.

assinged

> Source/WebCore/ChangeLog:13
> +	   Invalidate by following assinged node chain recursively instead of
just dumbly invalidating all host children.

assinged. Please use a more inclusive term than "dumbly"


More information about the webkit-reviews mailing list