[webkit-reviews] review granted: [Bug 232651] Make scroll bar mode an enum class : [Attachment 443175] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Nikos Mouchtaris
<nmouchtaris at apple.com>'s request for review:
Bug 232651: Make scroll bar mode an enum class
https://bugs.webkit.org/show_bug.cgi?id=232651

Attachment 443175: Patch

https://bugs.webkit.org/attachment.cgi?id=443175&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 443175
  --> https://bugs.webkit.org/attachment.cgi?id=443175
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443175&action=review

> Source/WebCore/page/FrameView.cpp:3525
> +    ScrollbarMode horizonalScrollbarMode = ScrollbarMode::AlwaysOff;
> +    ScrollbarMode verticalScrollbarMode = ScrollbarMode::AlwaysOff;

These could use auto.

> Source/WebCore/page/scrolling/ScrollingCoordinator.cpp:393
> +    ts.dumpProperty("horizontal scrollbar mode",
static_cast<int>(scrollableAreaParameters.horizontalScrollbarMode));
> +    ts.dumpProperty("vertical scrollbar mode",
static_cast<int>(scrollableAreaParameters.verticalScrollbarMode));

Ideally you'd fix this by implementing TextStream& operator<<(TextStream& ts,
ScrollbarMode)