[webkit-reviews] review denied: [Bug 230755] [css-flexbox] Improve & simplify the flex-basis computation : [Attachment 441350] Patch for landing

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 3 02:54:32 PDT 2021

Antti Koivisto <koivisto at iki.fi> has denied  review:
Bug 230755: [css-flexbox] Improve & simplify the flex-basis computation

Attachment 441350: Patch for landing


--- Comment #15 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 441350
  --> https://bugs.webkit.org/attachment.cgi?id=441350
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=441350&action=review

> Source/WebCore/rendering/RenderFlexibleBox.cpp:1012
> +	   m_child.mutableStyle().setLogicalHeight(Length(flexBasis));

This sort of hacks are not ok.

More information about the webkit-reviews mailing list