[webkit-reviews] review granted: [Bug 186344] font-synthesis inline/computed style in non-canonical : [Attachment 443153] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Nov 2 19:08:07 PDT 2021
Myles C. Maxfield <mmaxfield at apple.com> has granted Joonghun Park
<jh718.park at samsung.com>'s request for review:
Bug 186344: font-synthesis inline/computed style in non-canonical
https://bugs.webkit.org/show_bug.cgi?id=186344
Attachment 443153: Patch
https://bugs.webkit.org/attachment.cgi?id=443153&action=review
--- Comment #5 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 443153
--> https://bugs.webkit.org/attachment.cgi?id=443153
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=443153&action=review
r=mews
> Source/WebCore/css/StyleProperties.cpp:173
> + case CSSPropertyFontSynthesis:
> + return fontSynthesisPropertyValue(*value);
This is a surprising place for this code. Why is this here and not below (or
maybe even in another function?)
More information about the webkit-reviews
mailing list