[webkit-reviews] review granted: [Bug 231082] [WebIDL] Support [Exposed=*] extended attribute : [Attachment 443115] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Caitlin Potter (:caitp)
<caitp at igalia.com>'s request for review:
Bug 231082: [WebIDL] Support [Exposed=*] extended attribute
https://bugs.webkit.org/show_bug.cgi?id=231082

Attachment 443115: Patch

https://bugs.webkit.org/attachment.cgi?id=443115&action=review




--- Comment #15 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 443115
  --> https://bugs.webkit.org/attachment.cgi?id=443115
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443115&action=review

r=me with updated comment.

>> Source/WebCore/bindings/scripts/preprocess-idls.pl:61
>> +my @supportedGlobalContexts = (
> 
> This is the opposite of what I expected. I thought this would be "Window",
"Worker", "Worklet".
> This has an impact on which prototype object the property is exposed so it is
important to get right. Does the spec say which one is right (Your patch
proposal or my proposal?). If not, we may want to request that the
specification is clarified.

Ok, I just checked the spec and what you implemented seems to match the spec.
The spec says "only interfaces marked as "[Global]". Indeed,
DedicatedWorkerGlobalScope is marked as [Global] but not WorkerGlobalScope.

I think your comment should be clarified to mention that it should only
contains interfaces that have the [Global] extended attribute.