[webkit-reviews] review granted: [Bug 232550] [WebGPU] Bindings part 1: Bring back Adapter/Device bindings code : [Attachment 443044] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 232550: [WebGPU] Bindings part 1: Bring back Adapter/Device bindings code
https://bugs.webkit.org/show_bug.cgi?id=232550

Attachment 443044: Patch

https://bugs.webkit.org/attachment.cgi?id=443044&action=review




--- Comment #14 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 443044
  --> https://bugs.webkit.org/attachment.cgi?id=443044
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443044&action=review

> Source/WebCore/Modules/WebGPU/GPU.cpp:35
> +

nit: extra space

> Source/WebCore/Modules/WebGPU/GPUAdapter.cpp:35
> +

ditto

> Source/WebCore/bindings/scripts/CodeGenerator.pm:198
> -    die "Processing document " . $useDocument->fileName . " did not generate
anything.";
> +    # die "Processing document " . $useDocument->fileName . " did not
generate anything.";

Don't commit this.