[webkit-reviews] review granted: [Bug 232539] webpushd: Add mock in-memory registration, and the WKWebsiteDataStore SPI to manage them : [Attachment 442995] Patch v2

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 232539: webpushd: Add mock in-memory registration, and the
WKWebsiteDataStore SPI to manage them
https://bugs.webkit.org/show_bug.cgi?id=232539

Attachment 442995: Patch v2

https://bugs.webkit.org/attachment.cgi?id=442995&action=review




--- Comment #5 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 442995
  --> https://bugs.webkit.org/attachment.cgi?id=442995
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=442995&action=review

> Source/WebKit/webpushd/WebPushDaemon.h:62
> +    HashSet<String> m_inMemoryOriginStringsWithPermissionForTesting;

Why not make this a HashSet<SecurityOriginData>?  That would avoid a lot of
conversion back and forth, and it would prevent us from wondering if the String
was a valid origin string.