[webkit-reviews] review granted: [Bug 232571] [LFC][IFC] Stop measuring text while collecting inline items when content needs bidi split : [Attachment 442991] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 1 10:50:08 PDT 2021


Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 232571: [LFC][IFC] Stop measuring text while collecting inline items when
content needs bidi split
https://bugs.webkit.org/show_bug.cgi?id=232571

Attachment 442991: Patch

https://bugs.webkit.org/attachment.cgi?id=442991&action=review




--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 442991
  --> https://bugs.webkit.org/attachment.cgi?id=442991
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442991&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.h:57
> +    bool hasSeenBiDiContent() const { return
!m_paragraphContentBuilder.isEmpty(); }

Lets stay with bidi/Bidi since that is what most of the code uses.


More information about the webkit-reviews mailing list