[webkit-reviews] review granted: [Bug 226446] Stop using WTF_IGNORES_THREAD_SAFETY_ANALYSIS in MediaRecorderPrivateWriter code : [Attachment 430165] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon May 31 16:51:30 PDT 2021
Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 226446: Stop using WTF_IGNORES_THREAD_SAFETY_ANALYSIS in
MediaRecorderPrivateWriter code
https://bugs.webkit.org/show_bug.cgi?id=226446
Attachment 430165: Patch
https://bugs.webkit.org/attachment.cgi?id=430165&action=review
--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 430165
--> https://bugs.webkit.org/attachment.cgi?id=430165
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=430165&action=review
> Source/WebCore/ChangeLog:10
> + this thread safety checks do not apply to destructors.
"this" -> "since"
Seems like this doesn’t really make anything safer! Just quiets the compiler.
More information about the webkit-reviews
mailing list