[webkit-reviews] review granted: [Bug 226432] Drop UncheckedCondition / UncheckedLock : [Attachment 430137] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun May 30 11:40:13 PDT 2021

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 226432: Drop UncheckedCondition / UncheckedLock

Attachment 430137: Patch


--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 430137
  --> https://bugs.webkit.org/attachment.cgi?id=430137

View in context: https://bugs.webkit.org/attachment.cgi?id=430137&action=review

> Source/WTF/wtf/Lock.h:146
> +template<typename LockType> inline void assertIsHeld(const LockType& lock) {
ASSERT_UNUSED(lock, lock.isLocked()); }

Why is this template needed? What classes is this used on besides Lock? Is a
template the best way to do this, or would simple overloading be better?

More information about the webkit-reviews mailing list