[webkit-reviews] review canceled: [Bug 226425] Adopt BifurcatedGraphicsContext for backing store + display list RemoteLayerBackingStore : [Attachment 430113] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has canceled Tim Horton <thorton at apple.com>'s
request for review:
Bug 226425: Adopt BifurcatedGraphicsContext for backing store + display list
RemoteLayerBackingStore
https://bugs.webkit.org/show_bug.cgi?id=226425

Attachment 430113: Patch

https://bugs.webkit.org/attachment.cgi?id=430113&action=review




--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 430113
  --> https://bugs.webkit.org/attachment.cgi?id=430113
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430113&action=review

Needs a bunch more ifdefs, too.

> Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.h:60
> +    void ensureBackingStore(Type, WebCore::FloatSize, float scale, bool
deepColor, bool isOpaque, bool includeDisplayList);

Should not be just a bool

> Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:298
> +    m_frontBuffer.imageBuffer->flushDrawingContextAsync();
> +
> +    m_frontBufferFlusher = m_frontBuffer.imageBuffer->createFlusher();

Need to make sure that it's OK to not flush the DL ImageBuffer.