[webkit-reviews] review granted: [Bug 226281] Stop using UncheckedLock in JSDOMGlobalObject : [Attachment 429897] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri May 28 16:44:39 PDT 2021
Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 226281: Stop using UncheckedLock in JSDOMGlobalObject
https://bugs.webkit.org/show_bug.cgi?id=226281
Attachment 429897: Patch
https://bugs.webkit.org/attachment.cgi?id=429897&action=review
--- Comment #15 from Darin Adler <darin at apple.com> ---
Comment on attachment 429897
--> https://bugs.webkit.org/attachment.cgi?id=429897
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=429897&action=review
> Source/WebCore/bindings/js/JSDOMGlobalObject.cpp:259
> + // The GC thread has to grab the gc lock even though it is not
mutating the containers.
I would capitalize "gc" both times.
More information about the webkit-reviews
mailing list