[webkit-reviews] review granted: [Bug 226374] Go to network in case fetch event is not yet responded when being destroyed instead of failing the load : [Attachment 430007] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 28 09:15:46 PDT 2021


Alex Christensen <achristensen at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 226374: Go to network in case fetch event is not yet responded when being
destroyed instead of failing the load
https://bugs.webkit.org/show_bug.cgi?id=226374

Attachment 430007: Patch

https://bugs.webkit.org/attachment.cgi?id=430007&action=review




--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 430007
  --> https://bugs.webkit.org/attachment.cgi?id=430007
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430007&action=review

> Source/WebCore/testing/ServiceWorkerInternals.cpp:63
> +	   if (!result.has_value()) {

It looks like this whole change could just be a value_or({ })


More information about the webkit-reviews mailing list