[webkit-reviews] review granted: [Bug 226315] [LFC] Transition containing block 'for' loops to range loops : [Attachment 429947] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 28 06:37:20 PDT 2021


Antti Koivisto <koivisto at iki.fi> has granted  review:
Bug 226315: [LFC] Transition containing block 'for' loops to range loops
https://bugs.webkit.org/show_bug.cgi?id=226315

Attachment 429947: Patch

https://bugs.webkit.org/attachment.cgi?id=429947&action=review




--- Comment #4 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 429947
  --> https://bugs.webkit.org/attachment.cgi?id=429947
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429947&action=review

> Source/WebCore/layout/formattingContexts/block/BlockFormattingContext.cpp:235
> +	   for (auto& ancestor : containingBlockChain(layoutBox, root()))

I like how you are utilizing block chain technology here.

Might consider a helper for this case,
"containingBlockChainWithinFormattingContext" or similar.


More information about the webkit-reviews mailing list