[webkit-reviews] review granted: [Bug 225961] [GStreamer] Incorrect rendering of VP9 with transparency : [Attachment 429901] Patch

[bugzilla-daemon at webkit.org]

Zan Dobersek <zan at falconsigh.net> has granted Miguel Gomez
<magomez at igalia.com>'s request for review:
Bug 225961: [GStreamer] Incorrect rendering of VP9 with transparency
https://bugs.webkit.org/show_bug.cgi?id=225961

Attachment 429901: Patch

https://bugs.webkit.org/attachment.cgi?id=429901&action=review




--- Comment #5 from Zan Dobersek <zan at falconsigh.net> ---
Comment on attachment 429901
  --> https://bugs.webkit.org/attachment.cgi?id=429901
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429901&action=review

> Source/WebCore/platform/graphics/gstreamer/ImageGStreamerCairo.cpp:91
> +		   // These store the source pixel components.
> +		   unsigned short red;
> +		   unsigned short green;
> +		   unsigned short blue;
> +		   unsigned short alpha;
> +		   // These store the component offset inside the pixel for the
destination surface.
> +		   unsigned short redIndex;
> +		   unsigned short greenIndex;
> +		   unsigned short blueIndex;
> +		   unsigned short alphaIndex;

These could be explicitly using the uint16_t type. Bonus points for using
uint8_t in place of unsigned char (or unsigned char*).