[webkit-reviews] review granted: [Bug 226258] AirAllocateStackByGraphColoring should use the optimized interference graphs from AirAllocateRegistersByGraphColoring : [Attachment 429934] Patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has granted Robin Morisset
<rmorisset at apple.com>'s request for review:
Bug 226258: AirAllocateStackByGraphColoring should use the optimized
interference graphs from AirAllocateRegistersByGraphColoring
https://bugs.webkit.org/show_bug.cgi?id=226258

Attachment 429934: Patch

https://bugs.webkit.org/attachment.cgi?id=429934&action=review




--- Comment #8 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 429934
  --> https://bugs.webkit.org/attachment.cgi?id=429934
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429934&action=review

> Source/JavaScriptCore/b3/air/AirAllocateRegistersByGraphColoring.cpp:1365
> +	   if constexpr (reportInterferenceGraphMemoryUse &&
(std::is_same<InterferenceSet, WTF::LargeInterferenceGraph>::value ||
std::is_same<InterferenceSet, WTF::HugeInterferenceGraph>::value)) {

You should do “using WTF::LargeInterferenceGraph” (and ditto for Huge) at the
bottom of the file in WTF that defines these things. That way you don’t have to
say WTF:: here. That’s what other WTF ADTs do.