[webkit-reviews] review granted: [Bug 226236] [webkitpy] Use existing signal handler when printing stacktrace : [Attachment 429950] Patch

[bugzilla-daemon at webkit.org]

dewei_zhu at apple.com has granted Jonathan Bedard <jbedard at apple.com>'s request
for review:
Bug 226236: [webkitpy] Use existing signal handler when printing stacktrace
https://bugs.webkit.org/show_bug.cgi?id=226236

Attachment 429950: Patch

https://bugs.webkit.org/attachment.cgi?id=429950&action=review




--- Comment #6 from dewei_zhu at apple.com ---
Comment on attachment 429950
  --> https://bugs.webkit.org/attachment.cgi?id=429950
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429950&action=review

r=me

> Tools/Scripts/webkitpy/common/interrupt_debugging.py:66
> +def log_stack_trace_on_signal(signum, output_file=None):

Would it a better logging info if we pass sig_name instead of signum?

log_stack_trace_on_signal('SIGTERM', output_file=stack_trace_path)
log_stack_trace_on_signal('SIGINT', output_file=stack_trace_path)