[webkit-reviews] review granted: [Bug 226356] [GPU Process] Add debug logging around some shared display list codepaths : [Attachment 429930] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 226356: [GPU Process] Add debug logging around some shared display list
codepaths
https://bugs.webkit.org/show_bug.cgi?id=226356

Attachment 429930: Patch

https://bugs.webkit.org/attachment.cgi?id=429930&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 429930
  --> https://bugs.webkit.org/attachment.cgi?id=429930
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429930&action=review

> Source/WebKit/GPUProcess/graphics/RemoteImageBuffer.h:96
> +	       LOG(SharedDisplayLists, "Acknowledging Flush{%" PRIu64 "} in
Image(%" PRIu64 ")", identifier.toUInt64(),
m_renderingResourceIdentifier.toUInt64());

LOG_WITH_STREAM avoids the need for PRIu64 shenanigans.