[webkit-reviews] review requested: [Bug 226258] AirAllocateStackByGraphColoring should use the optimized interference graphs from AirAllocateRegistersByGraphColoring : [Attachment 429915] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu May 27 13:19:26 PDT 2021
Robin Morisset <rmorisset at apple.com> has asked for review:
Bug 226258: AirAllocateStackByGraphColoring should use the optimized
interference graphs from AirAllocateRegistersByGraphColoring
https://bugs.webkit.org/show_bug.cgi?id=226258
Attachment 429915: Patch
https://bugs.webkit.org/attachment.cgi?id=429915&action=review
--- Comment #5 from Robin Morisset <rmorisset at apple.com> ---
Created attachment 429915
--> https://bugs.webkit.org/attachment.cgi?id=429915&action=review
Patch
The test failures were caused by a debugging option that I had forgotten to
reset to false before committing
(AirAllocateStackByGraphColoringInternal::reportLargeMemoryUses).
I also tested it on JetStream2 and RAMification, and the patch appears neutral.
More information about the webkit-reviews
mailing list