[webkit-reviews] review granted: [Bug 226055] [iOS] contextmenu hints don't follow scrolling inside `<iframe>` : [Attachment 429244] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 27 11:56:00 PDT 2021


Tim Horton <thorton at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 226055: [iOS] contextmenu hints don't follow scrolling inside `<iframe>`
https://bugs.webkit.org/show_bug.cgi?id=226055

Attachment 429244: Patch

https://bugs.webkit.org/attachment.cgi?id=429244&action=review




--- Comment #4 from Tim Horton <thorton at apple.com> ---
Comment on attachment 429244
  --> https://bugs.webkit.org/attachment.cgi?id=429244
Patch

You should sell it as "a step on the path to the generic solution" instead :)

For example, we totally do vend the view that UIKit installs the selection
highlights into, so you could imagine reusing this mechanism for those (in
reality I think it's possible they expect it to have the same coordinate space
as WKContentView, would require some digging to see if it's directly reusable).


More information about the webkit-reviews mailing list