[webkit-reviews] review requested: [Bug 226343] Add stub implementation of CA separated portal bits for GraphicsLayer : [Attachment 429902] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has asked	for review:
Bug 226343: Add stub implementation of CA separated portal bits for
GraphicsLayer
https://bugs.webkit.org/show_bug.cgi?id=226343

Attachment 429902: Patch

https://bugs.webkit.org/attachment.cgi?id=429902&action=review




--- Comment #5 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 429902
  --> https://bugs.webkit.org/attachment.cgi?id=429902
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429902&action=review

> Source/WebCore/ChangeLog:8
> +	   Plumbs isSeparatedPortal and isDescendentOfSeparatedPortal bits
through GraphicsLayer.

Plumbs

> Source/WebCore/platform/graphics/GraphicsLayer.h:406
> +    virtual void setIsDescendentOfSeparatedPortal(bool b) {
m_isDescendentOfSeparatedPortal = b; }

Does this need to be exposed? We can compute this internally in GraphicsLayer
while flushing.

> Source/WebCore/platform/graphics/GraphicsLayer.h:744
> +    bool m_isSeparatedPortal : 1;

There's some ambiguity here. Does m_isSeparatedPortal being true imply that
m_isSeparated is also true?