[webkit-reviews] review granted: [Bug 226320] [GTK] Try harder to find initial WebKitWebView size : [Attachment 429860] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at gnome.org> has granted Alexander Mikhaylenko
<alexm at gnome.org>'s request for review:
Bug 226320: [GTK] Try harder to find initial WebKitWebView size
https://bugs.webkit.org/show_bug.cgi?id=226320

Attachment 429860: Patch

https://bugs.webkit.org/attachment.cgi?id=429860&action=review




--- Comment #6 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 429860
  --> https://bugs.webkit.org/attachment.cgi?id=429860
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429860&action=review

This looks good to me.

I would add a comment though, to explain why we are doing this, why it's not
going to return a perfect result but is better than (0, 0), and probably also
link to this bug report so we don't remove it by mistake in the future.

BTW it's already mentioned in the patch changelog, but I'll link to it here as
well: this is to fix https://gitlab.gnome.org/GNOME/epiphany/-/issues/1532.

> Source/WebKit/ChangeLog:10
> +	   size, which will be (0, 0) because the drawing area ist still null

is

> Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:2376
> +    // everything is fine and we'll just use that

Nit: that. with a period.

> Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:2383
> +    // through the hierarchy and try to find a parent with non-0 size

Nit: size. with a period.