[webkit-reviews] review granted: [Bug 212327] [GTK4] Add support for navigation gestures : [Attachment 429857] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 27 07:09:19 PDT 2021

Michael Catanzaro <mcatanzaro at gnome.org> has granted Alexander Mikhaylenko
<alexm at gnome.org>'s request for review:
Bug 212327: [GTK4] Add support for navigation gestures

Attachment 429857: Patch


--- Comment #15 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 429857
  --> https://bugs.webkit.org/attachment.cgi?id=429857

View in context: https://bugs.webkit.org/attachment.cgi?id=429857&action=review

r=me, but we need an owner to approve the change imageSizeInBytes() ->

> Source/WebKit/UIProcess/ViewSnapshotStore.h:89
> -    size_t imageSizeInBytes() const { return m_surface ?
m_surface->totalBytes() : 0; }
> +    size_t estimateImageSizeInBytes() const { return m_surface ?
m_surface->totalBytes() : 0; }

Hi Chris, we need an owner for this... can you approve this change please?

The problem is our new ViewSnapshotStore implementation doesn't actually know
for sure how large its snapshots are -- that's hidden behind an abstraction
layer -- so we have to guess. It means the cache size limit won't be perfectly
respected if our guess is wrong. Won't make a difference for Apple ports since
your "estimate" is not changed and will always be exact.

More information about the webkit-reviews mailing list