[webkit-reviews] review granted: [Bug 221202] Webkit doesn't calculate padding-top/-bottom in % correctly when parent has padding : [Attachment 427976] Patch

[bugzilla-daemon at webkit.org]

Manuel Rego Casasnovas <rego at igalia.com> has granted Rob Buis
<rbuis at igalia.com>'s request for review:
Bug 221202: Webkit doesn't calculate padding-top/-bottom in % correctly when
parent has padding
https://bugs.webkit.org/show_bug.cgi?id=221202

Attachment 427976: Patch

https://bugs.webkit.org/attachment.cgi?id=427976&action=review




--- Comment #12 from Manuel Rego Casasnovas <rego at igalia.com> ---
Comment on attachment 427976
  --> https://bugs.webkit.org/attachment.cgi?id=427976
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427976&action=review

r=me

> Source/WebCore/ChangeLog:9
> +	   https://www.w3.org/TR/CSS2/visudet.html#containing-block-details
(4.2).

Nit: Maybe you can link the new CSS specs here, as this is quite an old
reference:
https://drafts.csswg.org/css-position-3/#absolute-positioning-containing-block