[webkit-reviews] review granted: [Bug 226294] Use timingsafe_bcmp() in WTF::constantTimeMemcmp() when available : [Attachment 429795] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 226294: Use timingsafe_bcmp() in WTF::constantTimeMemcmp() when available
https://bugs.webkit.org/show_bug.cgi?id=226294

Attachment 429795: Patch

https://bugs.webkit.org/attachment.cgi?id=429795&action=review




--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 429795
  --> https://bugs.webkit.org/attachment.cgi?id=429795
Patch

Oh, I was looking at the bsd documentation, which has both.
memcmp implies a directional return value that can be used in sorting, but this
doesn't have that property.  Our use only checks whether it's zero, though, so
it's fine so far.