[webkit-reviews] review granted: [Bug 226290] Add logging for when SQLiteDatabase fails to close : [Attachment 429793] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 26 15:51:42 PDT 2021
Chris Dumez <cdumez at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 226290: Add logging for when SQLiteDatabase fails to close
https://bugs.webkit.org/show_bug.cgi?id=226290
Attachment 429793: Patch
https://bugs.webkit.org/attachment.cgi?id=429793&action=review
--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 429793
--> https://bugs.webkit.org/attachment.cgi?id=429793
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=429793&action=review
r=me with nits
> Source/WebCore/platform/sql/SQLiteDatabase.cpp:238
> + RELEASE_LOG_ERROR(SQLDatabase, "SQLiteDatabase::close: Failed to
close database (%d) - %s", lastError(), lastErrorMsg());
Do you want a LOG_ERROR() too? I don't think you'll see the RELEASE_LOG_ERROR()
on the bots' output, unless you get a sysdiagnose.
Also, you want to use %{public}s (assuming not privacy sensitive, %{private}s
otherwise) on the string so the actually gets printed out in a RELEASE_LOG.
> Source/WebCore/platform/sql/SQLiteDatabase.h:62
> + enum class ShouldSetErrorState { No, Yes };
enum class ShouldSetErrorState : bool { No, Yes };
More information about the webkit-reviews
mailing list