[webkit-reviews] review granted: [Bug 226269] [LFC] Introduce containingBlockChainOf : [Attachment 429758] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 226269: [LFC] Introduce containingBlockChainOf
https://bugs.webkit.org/show_bug.cgi?id=226269

Attachment 429758: Patch

https://bugs.webkit.org/attachment.cgi?id=429758&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 429758
  --> https://bugs.webkit.org/attachment.cgi?id=429758
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429758&action=review

> Source/WebCore/layout/formattingContexts/table/TableFormattingQuirks.cpp:70
> +    for (auto& ancestor : containingBlockChainOf(layoutBox)) {

Not sure if the "Of" adds anything.

> Source/WebCore/layout/layouttree/LayoutContainingBlockChainIterator.h:54
> +    LayoutContainingBlockChainIterator begin() { return
LayoutContainingBlockChainIterator(m_containingBlock); }
> +    LayoutContainingBlockChainIterator end() { return
LayoutContainingBlockChainIterator(); }

could be 

auto begin()
auto end()