[webkit-reviews] review granted: [Bug 226255] Stop using UncheckedLock in WTF::AutomaticThread : [Attachment 429727] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 26 08:04:08 PDT 2021

Keith Miller <keith_miller at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 226255: Stop using UncheckedLock in WTF::AutomaticThread

Attachment 429727: Patch


--- Comment #4 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 429727
  --> https://bugs.webkit.org/attachment.cgi?id=429727

View in context: https://bugs.webkit.org/attachment.cgi?id=429727&action=review

> Source/WTF/wtf/ParallelHelperPool.cpp:189
> +	   assertIsHeld(*m_pool.m_lock);

Why not just annotate the poll function? Or does this only work for locks that
are a member of the same class as the method?

More information about the webkit-reviews mailing list