[webkit-reviews] review granted: [Bug 226228] Introduce a shared IDB serialization thread : [Attachment 429705] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 26 07:52:33 PDT 2021
Chris Dumez <cdumez at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 226228: Introduce a shared IDB serialization thread
https://bugs.webkit.org/show_bug.cgi?id=226228
Attachment 429705: Patch
https://bugs.webkit.org/attachment.cgi?id=429705&action=review
--- Comment #5 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 429705
--> https://bugs.webkit.org/attachment.cgi?id=429705
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=429705&action=review
We may want to add threading assertions to the serialization / deserialization
functions to make sure they are called on the expected thread?
> Source/WebCore/Modules/indexeddb/server/IDBSerialization.cpp:428
> + IDBSerializationContext()
Please make constructor private and add a create() factory function, like we do
for all RefCounted classes.
Or maybe even better, don't subclass RefCounted and use a stack object? It is
unclear why this is RefCounted based on how it is used currently.
More information about the webkit-reviews
mailing list