[webkit-reviews] review granted: [Bug 211674] Switch from WTF::Optional to std::optional : [Attachment 429657] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 25 12:27:43 PDT 2021

Chris Dumez <cdumez at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 211674: Switch from WTF::Optional to std::optional

Attachment 429657: Patch


--- Comment #24 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 429657
  --> https://bugs.webkit.org/attachment.cgi?id=429657

View in context: https://bugs.webkit.org/attachment.cgi?id=429657&action=review


> Source/JavaScriptCore/runtime/IntlDateTimeFormat.cpp:310
> +    return options;

I would have updated early returns to return nullptr instead of { }. I assume
it is equivalent but I am not 100% sure.

More information about the webkit-reviews mailing list