[webkit-reviews] review granted: [Bug 226225] [AppleWin] JSC fails to build : [Attachment 429663] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 25 11:08:23 PDT 2021


Brent Fulgham <bfulgham at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 226225: [AppleWin] JSC fails to build
https://bugs.webkit.org/show_bug.cgi?id=226225

Attachment 429663: Patch

https://bugs.webkit.org/attachment.cgi?id=429663&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 429663
  --> https://bugs.webkit.org/attachment.cgi?id=429663
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429663&action=review

r=me

> Source/WTF/wtf/CMakeLists.txt:-588
> -)

It seems like you could keep this variable and leave the COPY command as it is,
with the only change being the command to create the directory (and the new log
message).


More information about the webkit-reviews mailing list