[webkit-reviews] review granted: [Bug 226124] Make error returned by SQLiteIDBBackingStore::getOrEstablishDatabaseInfo more detailed : [Attachment 429562] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 226124: Make error returned by
SQLiteIDBBackingStore::getOrEstablishDatabaseInfo more detailed
https://bugs.webkit.org/show_bug.cgi?id=226124

Attachment 429562: Patch

https://bugs.webkit.org/attachment.cgi?id=429562&action=review




--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 429562
  --> https://bugs.webkit.org/attachment.cgi?id=429562
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429562&action=review

> Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:-262
> -	       LOG_ERROR("Unable to prepare statement to fetch schema for the
Records table.");

Unclear why this patch is getting rid of all the LOG_ERROR(). You can both
LOG_ERROR AND return a useful IDBError. Why trade one for the other?

> Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:257
> +    String tableStatement = database.tableSQL("Records"_s);

Why is it named Statement and not schema like it used to be? If I see
statement, I expect a SQLiteStatement.

> Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:262
> +	   return IDBError { };

wouldn't `return { };` work?

> Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:267
> +	   return IDBError { };

wouldn't `return { };` work?

> Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:293
> +    return IDBError { };

wouldn't `return { };` work?