[webkit-reviews] review granted: [Bug 226096] Finalize DFG/FTL code refs on the compiler threads : [Attachment 429602] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 24 20:52:07 PDT 2021

Mark Lam <mark.lam at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 226096: Finalize DFG/FTL code refs on the compiler threads

Attachment 429602: patch


--- Comment #8 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 429602
  --> https://bugs.webkit.org/attachment.cgi?id=429602

View in context: https://bugs.webkit.org/attachment.cgi?id=429602&action=review


>> Source/JavaScriptCore/assembler/LinkBuffer.cpp:49
>> +	    RELEASE_ASSERT(m_mainThreadFinalizationTasks.isEmpty());
> I’ll remove this RELEASE_ASSERT. It’s taking a lot of plumbing to make it
work. Which is usually a bad reason to keep an assert

I'm fine with removing it.  The failure was at VM destruction, and
m_mainThreadFinalizationTasks will get cleaned out anyway.

More information about the webkit-reviews mailing list