[webkit-reviews] review granted: [Bug 226208] Stop using UncheckedLock in DatabaseTracker : [Attachment 429613] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon May 24 20:11:20 PDT 2021
Sam Weinig <sam at webkit.org> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 226208: Stop using UncheckedLock in DatabaseTracker
https://bugs.webkit.org/show_bug.cgi?id=226208
Attachment 429613: Patch
https://bugs.webkit.org/attachment.cgi?id=429613&action=review
--- Comment #2 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 429613
--> https://bugs.webkit.org/attachment.cgi?id=429613
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=429613&action=review
> Source/WebCore/ChangeLog:14
> + In this particular instance, I have opted to annotate the functions
that gave out
> + warning with WTF_IGNORES_THREAD_SAFETY_ANALYSIS. I initially tried
to use proper
> + annotations (WTF_ACQUIRES_LOCK() / WTF_RELEASES_LOCK()). However,
the call sites are
> + Objective C functions and I am unable to annotate those.
I think adding a comment to the code explaining this would be helpful for
future readers.
More information about the webkit-reviews
mailing list