[webkit-reviews] review granted: [Bug 226165] [CoordinatedGraphics] Handle null native surface handle for surfaceless rendering : [Attachment 429509] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 24 08:20:10 PDT 2021


Philippe Normand <pnormand at igalia.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 226165: [CoordinatedGraphics] Handle null native surface handle for
surfaceless rendering
https://bugs.webkit.org/show_bug.cgi?id=226165

Attachment 429509: Patch

https://bugs.webkit.org/attachment.cgi?id=429509&action=review




--- Comment #2 from Philippe Normand <pnormand at igalia.com> ---
Comment on attachment 429509
  --> https://bugs.webkit.org/attachment.cgi?id=429509
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429509&action=review

>
Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.
cpp:74
> +	   if (m_context) {

Nit: this could be reversed and early return.


More information about the webkit-reviews mailing list