[webkit-reviews] review granted: [Bug 225650] [WTF][GStreamer] Add RAII lockers for 3rd party locks : [Attachment 428817] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Alicia Boya García
<aboya at igalia.com>'s request for review:
Bug 225650: [WTF][GStreamer] Add RAII lockers for 3rd party locks
https://bugs.webkit.org/show_bug.cgi?id=225650

Attachment 428817: Patch

https://bugs.webkit.org/attachment.cgi?id=428817&action=review




--- Comment #7 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 428817
  --> https://bugs.webkit.org/attachment.cgi?id=428817
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428817&action=review

> Source/WTF/wtf/Locker.h:188
> +    explicit ExternalLocker(T* lockable) : m_lockable(lockable) { lock(); }

You missed this ASSERT.

> Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h:331
> +    return GstObjectLocker(gstObject);

Ditto.

> Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h:337
> +    return GstPadStreamLocker(pad);

Ditto.