[webkit-reviews] review granted: [Bug 226149] Use singleton thunks for virtual calls. : [Attachment 429457] proposed patch.

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 226149: Use singleton thunks for virtual calls.
https://bugs.webkit.org/show_bug.cgi?id=226149

Attachment 429457: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=429457&action=review




--- Comment #5 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 429457
  --> https://bugs.webkit.org/attachment.cgi?id=429457
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=429457&action=review

r=me

> Source/JavaScriptCore/ChangeLog:13
> +	   2. Introduce Options::useUniqueVirtualThunks() to allow unique
thunks to be
> +	      generated for testing and comparisons. 
Options::useUniqueVirtualThunks() is
> +	      false by default.

Maybe this flag is not necessary.

> Source/JavaScriptCore/jit/ThunkGenerators.cpp:275
> +    bool isTailCall = (mode == CallMode::Tail);

() is not necessary.