[webkit-reviews] review granted: [Bug 226118] ASSERTION FAILED: Component at index 1 is 1.000000 and is greater than the allowed maximum 1.000000 : [Attachment 429387] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 226118: ASSERTION FAILED: Component at index 1 is 1.000000 and is greater
than the allowed maximum 1.000000
https://bugs.webkit.org/show_bug.cgi?id=226118

Attachment 429387: Patch

https://bugs.webkit.org/attachment.cgi?id=429387&action=review




--- Comment #6 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 429387
  --> https://bugs.webkit.org/attachment.cgi?id=429387
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429387&action=review

> Source/WebCore/platform/graphics/cg/ColorCG.cpp:86
> -    return convertColor<SRGBA<uint8_t>>(SRGBA<float> { r, g, b, a });
> +    return
convertColor<SRGBA<uint8_t>>(makeFromComponentsClamping<SRGBA<float>>(r, g, b,
a ));

This is a good short term fix for the tests, but I need to fix this function to
do something actually reasonable here. I'll tackle that in
https://bugs.webkit.org/show_bug.cgi?id=226141.