[webkit-reviews] review granted: [Bug 226066] [Cocoa] REGRESSION(Sandbox): Font smoothing within Safari doesn't seem to respect AppleFontSmoothing : [Attachment 429262] Patch

[bugzilla-daemon at webkit.org]

Per Arne Vollan <pvollan at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 226066: [Cocoa] REGRESSION(Sandbox): Font smoothing within Safari doesn't
seem to respect AppleFontSmoothing
https://bugs.webkit.org/show_bug.cgi?id=226066

Attachment 429262: Patch

https://bugs.webkit.org/attachment.cgi?id=429262&action=review




--- Comment #3 from Per Arne Vollan <pvollan at apple.com> ---
Comment on attachment 429262
  --> https://bugs.webkit.org/attachment.cgi?id=429262
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429262&action=review

R=me.

> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:2310
> +
> +#if ENABLE(CFPREFS_DIRECT_MODE)
> +(allow file-read*
> +    (home-regex
"/Library/Preferences/ByHost/\.GlobalPreferences\..*\.plist$")
> +)
> +#endif

There's already a section with ENABLE(CFPREFS_DIRECT_MODE). Perhaps you could
move this there to have it all in one place?